Files
genieacs/ui/presets-page.ts
Zaid Humaimidi 6f3ce6f7c8 refactor: replace array-based expressions with typed class hierarchy
Replace the old Lisp-like array expression representation
(["AND", ["PARAM", ...], ...]) with a class hierarchy rooted in
an abstract Expression class (Literal, Parameter, Binary, Unary,
FunctionCall, Conditional). This gives compile-time type safety
to expression construction, evaluation, and pattern matching.

Key changes:
- New lib/common/expression.ts defines the class hierarchy with
  map/evaluate/toString methods
- Rewrite parser as hand-rolled recursive descent, removing the
  parsimmon dependency
- Extend Path with a colon separator to unify parameter identity
  and attributes into a single address space (e.g.
  "Device.WiFi.SSID.1.Name:writable"). The colon field tracks
  how many trailing segments are attribute qualifiers. PathSet
  rewritten with separate param/attr segment indexes
- Flatten device attribute representation in the UI to
  colon-delimited keys mirroring the new path syntax
2026-03-12 14:58:20 -07:00

466 lines
15 KiB
TypeScript

import { ClosureComponent, Component, Children, Vnode } from "mithril";
import { m } from "./components.ts";
import { pageSize as PAGE_SIZE } from "./config.ts";
import filterComponent from "./filter-component.ts";
import * as overlay from "./overlay.ts";
import * as store from "./store.ts";
import * as notifications from "./notifications.ts";
import putFormComponent from "./put-form-component.ts";
import indexTableComponent from "./index-table-component.ts";
import memoize from "../lib/common/memoize.ts";
import * as smartQuery from "./smart-query.ts";
import Expression from "../lib/common/expression.ts";
const memoizedParse = memoize((str) => Expression.parse(str));
const memoizedJsonParse = memoize(JSON.parse);
const attributes = [
{ id: "_id", label: "Name" },
{ id: "channel", label: "Channel" },
{ id: "weight", label: "Weight" },
{ id: "schedule", label: "Schedule" },
{ id: "events", label: "Events" },
{ id: "precondition", label: "Precondition", type: "textarea" },
{ id: "provision", label: "Provision", type: "combo" },
{ id: "provisionArgs", label: "Arguments", type: "textarea" },
];
const unpackSmartQuery = memoize((query: Expression) => {
return query.evaluate((e) => {
if (e instanceof Expression.FunctionCall) {
if (e.name === "Q") {
if (
e.args[0] instanceof Expression.Literal &&
e.args[1] instanceof Expression.Literal
) {
return smartQuery.unpack(
"presets",
e.args[0].value as string,
e.args[1].value as string,
);
}
}
}
return e;
});
});
interface ValidationErrors {
[prop: string]: string;
}
function getExcerpt(text: string, maxLength = 80, maxLines = 10): string[] {
let lines: string[] = text?.split("\n", maxLines + 1) ?? [""];
if (lines.length > maxLines) {
lines.pop();
lines[maxLines - 1] = "\ufe19";
}
lines = lines.map((l) => {
if (l.length <= maxLength) return l;
return l.slice(0, maxLength - 1) + "\u2026";
});
return lines;
}
function putActionHandler(action, _object, isNew): Promise<ValidationErrors> {
return new Promise((resolve, reject) => {
const object = Object.assign({}, _object);
if (action === "save") {
const id = object["_id"];
delete object["_id"];
const errors = {};
if (!id) errors["_id"] = "ID can not be empty";
if (!object.provision) errors["provision"] = "Provision not selected";
if (Object.keys(errors).length) return void resolve(errors);
if (object.precondition) {
try {
object.precondition = memoizedParse(object.precondition).toString();
} catch {
return void resolve({
precondition: "Precondition must be valid expression",
});
}
}
store
.resourceExists("presets", id)
.then((exists) => {
if (exists && isNew) {
store.setTimestamp(Date.now());
return void resolve({ _id: "Preset already exists" });
}
if (!exists && !isNew) {
store.setTimestamp(Date.now());
return void resolve({ _id: "Preset does not exist" });
}
store
.putResource("presets", id, object)
.then(() => {
notifications.push(
"success",
`Preset ${exists ? "updated" : "created"}`,
);
store.setTimestamp(Date.now());
resolve(null);
})
.catch(reject);
})
.catch(reject);
} else if (action === "delete") {
if (!confirm("Deleting preset. Are you sure?")) return void resolve(null);
store
.deleteResource("presets", object["_id"])
.then(() => {
notifications.push("success", "Preset deleted");
store.setTimestamp(Date.now());
resolve(null);
})
.catch((err) => {
reject(err);
store.setTimestamp(Date.now());
});
} else {
reject(new Error("Undefined action"));
}
});
}
const formData = {
resource: "presets",
attributes: attributes,
};
const getDownloadUrl = memoize((filter) => {
const cols = {};
for (const attr of attributes) cols[attr.label] = attr.id;
return `api/presets.csv?${m.buildQueryString({
filter: filter.toString(),
columns: JSON.stringify(cols),
})}`;
});
export function init(
args: Record<string, unknown>,
): Promise<Record<string, unknown>> {
if (!window.authorizer.hasAccess("presets", 2)) {
return Promise.reject(
new Error("You are not authorized to view this page"),
);
}
let filter: Expression = null;
let sort: Record<string, number> = null;
if (args.hasOwnProperty("filter"))
filter = Expression.parse(args["filter"] as string);
if (args.hasOwnProperty("sort")) sort = JSON.parse(args["sort"] as string);
return Promise.resolve({ filter, sort });
}
export const component: ClosureComponent = (): Component => {
return {
view: (vnode) => {
document.title = "Presets - GenieACS";
function showMore(): void {
vnode.state["showCount"] =
(vnode.state["showCount"] || PAGE_SIZE) + PAGE_SIZE;
m.redraw();
}
function onFilterChanged(filter): void {
const ops = {};
if (!(filter instanceof Expression.Literal && filter.value))
ops["filter"] = filter.toString();
if (vnode.attrs["sort"]) ops["sort"] = vnode.attrs["sort"];
m.route.set("/presets", ops);
}
const sort = vnode.attrs["sort"]
? memoizedJsonParse(vnode.attrs["sort"])
: {};
const sortAttributes = {};
for (let i = 0; i < attributes.length; i++) {
const attr = attributes[i];
if (
!(
attr.id === "events" ||
attr.id === "precondition" ||
attr.id === "provision" ||
attr.id === "provisionArgs"
)
)
sortAttributes[i] = sort[attr.id] || 0;
}
function onSortChange(sortAttrs): void {
const _sort = {};
for (const index of sortAttrs)
_sort[attributes[Math.abs(index) - 1].id] = Math.sign(index);
const ops = { sort: JSON.stringify(_sort) };
if (vnode.attrs["filter"]) ops["filter"] = vnode.attrs["filter"];
m.route.set("/presets", ops);
}
const filter = unpackSmartQuery(
vnode.attrs["filter"] ?? new Expression.Literal(true),
);
const presets = store.fetch("presets", filter, {
limit: vnode.state["showCount"] || PAGE_SIZE,
sort: sort,
});
const count = store.count("presets", filter);
const userDefinedProvisions: Set<string> = new Set();
const provisionIds = new Set([
"refresh",
"value",
"tag",
"reboot",
"reset",
"download",
"instances",
]);
const provisions = store.fetch(
"provisions",
new Expression.Literal(true),
);
if (provisions.fulfilled) {
for (const p of provisions.value) {
userDefinedProvisions.add(p["_id"]);
provisionIds.add(p["_id"]);
}
}
const provisionAttr = attributes.find((attr) => {
return attr.id === "provision";
});
provisionAttr["options"] = Array.from(provisionIds);
const downloadUrl = getDownloadUrl(filter);
const valueCallback = (attr, preset): Vnode => {
if (attr.id === "precondition") {
let devicesUrl = "#!/devices";
if (preset["precondition"].length) {
devicesUrl += `?${m.buildQueryString({
filter: preset["precondition"],
})}`;
}
return m(
"a.text-cyan-700 hover:text-cyan-900 font-mono",
{ href: devicesUrl, title: preset["precondition"] },
getExcerpt(preset["precondition"], 80, 1)[0],
);
} else if (attr.id === "provisionArgs") {
return m(
"span.font-mono",
{ title: preset["provisionArgs"] },
getExcerpt(preset["provisionArgs"], 80, 1)[0],
);
} else if (
attr.id === "provision" &&
userDefinedProvisions.has(preset[attr.id])
) {
return m(
"a.text-cyan-700 hover:text-cyan-900",
{
href: `#!/provisions?${m.buildQueryString({
filter: `Q("ID", "${preset["provision"]}")`,
})}`,
},
preset["provision"],
);
} else {
return preset[attr.id];
}
};
const attrs = {};
attrs["attributes"] = attributes;
attrs["data"] = presets.value;
attrs["total"] = count.value;
attrs["showMoreCallback"] = showMore;
attrs["sortAttributes"] = sortAttributes;
attrs["onSortChange"] = onSortChange;
attrs["downloadUrl"] = downloadUrl;
attrs["valueCallback"] = valueCallback;
attrs["recordActionsCallback"] = (preset) => {
return [
m(
"button.text-cyan-700 hover:text-cyan-900 font-medium",
{
onclick: () => {
let cb: () => Children = null;
const comp = m(
putFormComponent,
Object.assign(
{
base: preset,
actionHandler: (action, object) => {
return new Promise<void>((resolve) => {
putActionHandler(action, object, false)
.then((errors) => {
const errorList = errors
? Object.values(errors)
: [];
if (errorList.length) {
for (const err of errorList)
notifications.push("error", err);
} else {
overlay.close(cb);
}
resolve();
})
.catch((err) => {
notifications.push("error", err.message);
resolve();
});
});
},
},
formData,
),
);
cb = (): Children => {
if (!preset.provision) {
return m(
"div",
{ style: "margin:20px" },
"This UI only supports presets with a single 'provision' configuration. If this preset was originally created from the old UI (genieacs-gui), you must edit it there.",
);
}
return comp;
};
overlay.open(
cb,
() =>
!comp.state?.["current"]["modified"] ||
confirm("You have unsaved changes. Close anyway?"),
);
},
},
"Show",
),
];
};
if (window.authorizer.hasAccess("presets", 3)) {
attrs["actionsCallback"] = (selected: Set<string>): Children => {
return [
m(
"button.px-4 py-2 border border-stone-300 shadow-xs text-sm font-medium rounded-md text-stone-700 bg-white hover:bg-stone-50 focus:outline-hidden focus:ring-2 focus:ring-offset-2 focus:ring-cyan-500 disabled:opacity-50 disabled:cursor-not-allowed",
{
title: "Create new preset",
onclick: () => {
let cb: () => Children = null;
const comp = m(
putFormComponent,
Object.assign(
{
actionHandler: (action, object) => {
return new Promise<void>((resolve) => {
putActionHandler(action, object, true)
.then((errors) => {
const errorList = errors
? Object.values(errors)
: [];
if (errorList.length) {
for (const err of errorList)
notifications.push("error", err);
} else {
overlay.close(cb);
}
resolve();
})
.catch((err) => {
notifications.push("error", err.message);
resolve();
});
});
},
},
formData,
),
);
cb = () => comp;
overlay.open(
cb,
() =>
!comp.state["current"]["modified"] ||
confirm("You have unsaved changes. Close anyway?"),
);
},
},
"New",
),
m(
"button.px-4 py-2 border border-stone-300 shadow-xs text-sm font-medium rounded-md text-stone-700 bg-white hover:bg-stone-50 focus:outline-hidden focus:ring-2 focus:ring-offset-2 focus:ring-cyan-500 disabled:opacity-50 disabled:cursor-not-allowed",
{
title: "Delete selected presets",
disabled: !selected.size,
onclick: (e) => {
if (
!confirm(`Deleting ${selected.size} presets. Are you sure?`)
)
return;
e.redraw = false;
e.target.disabled = true;
Promise.all(
Array.from(selected).map((id) =>
store.deleteResource("presets", id),
),
)
.then((res) => {
notifications.push(
"success",
`${res.length} presets deleted`,
);
store.setTimestamp(Date.now());
})
.catch((err) => {
notifications.push("error", err.message);
store.setTimestamp(Date.now());
});
},
},
"Delete",
),
];
};
}
const filterAttrs = {
resource: "presets",
filter: vnode.attrs["filter"],
onChange: onFilterChanged,
};
return [
m("h1.text-xl font-medium text-stone-900 mb-5", "Listing presets"),
m(filterComponent, filterAttrs),
m(
"loading",
{ queries: [presets, count] },
m(indexTableComponent, attrs),
),
];
},
};
};