rodrigo/genieacs
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Apply consistent-return lint rule

Browse Source
This commit is contained in:
Zaid Abdulla committed 2018-08-25 03:22:48 -07:00
1 parent d7f0b91bf0
commit d85afcd2b5
12 files changed
+264 -231
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

lib/nbi.js
+42 -40
View File
@@ -84,10 +84,10 @@ function listener(request, response) {
const preset = JSON.parse(body);
preset._id = presetName;
db.presetsCollection.save(preset, err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
cache.del("presets_hash", err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
response.writeHead(200);
response.end();
@@ -95,10 +95,10 @@ function listener(request, response) {
});
} else if (request.method === "DELETE") {
db.presetsCollection.remove({ _id: presetName }, err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
cache.del("presets_hash", err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
response.writeHead(200);
response.end();
@@ -116,10 +116,10 @@ function listener(request, response) {
const object = JSON.parse(body);
object._id = objectName;
db.objectsCollection.save(object, err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
cache.del("presets_hash", err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
response.writeHead(200);
response.end();
@@ -127,10 +127,10 @@ function listener(request, response) {
});
} else if (request.method === "DELETE") {
db.objectsCollection.remove({ _id: objectName }, err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
cache.del("presets_hash", err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
response.writeHead(200);
response.end();
@@ -159,10 +159,10 @@ function listener(request, response) {
}
db.provisionsCollection.save(object, err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
cache.del("presets_hash", err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
response.writeHead(200);
response.end();
@@ -170,10 +170,10 @@ function listener(request, response) {
});
} else if (request.method === "DELETE") {
db.provisionsCollection.remove({ _id: provisionName }, err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
cache.del("presets_hash", err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
response.writeHead(200);
response.end();
@@ -202,10 +202,10 @@ function listener(request, response) {
}
db.virtualParametersCollection.save(object, err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
cache.del("presets_hash", err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
response.writeHead(200);
response.end();
@@ -215,10 +215,10 @@ function listener(request, response) {
db.virtualParametersCollection.remove(
{ _id: virtualParameterName },
err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
cache.del("presets_hash", err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
response.writeHead(200);
response.end();
@@ -239,7 +239,7 @@ function listener(request, response) {
{ $addToSet: { _tags: tag } },
{ safe: true },
err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
response.writeHead(200);
response.end();
}
@@ -250,7 +250,7 @@ function listener(request, response) {
{ $pull: { _tags: tag } },
{ safe: true },
err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
response.writeHead(200);
response.end();
@@ -268,15 +268,15 @@ function listener(request, response) {
const deviceId = faultId.split(":", 1)[0];
const channel = faultId.slice(deviceId.length + 1);
db.faultsCollection.remove({ _id: faultId }, err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
if (channel.startsWith("task_")) {
const objId = new mongodb.ObjectID(channel.slice(5));
return db.tasksCollection.remove({ _id: objId }, err => {
if (err) return throwError(err, response);
return void db.tasksCollection.remove({ _id: objId }, err => {
if (err) return void throwError(err, response);
cache.del(`${deviceId}_tasks_faults_operations`, err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
response.writeHead(200);
response.end();
@@ -285,7 +285,7 @@ function listener(request, response) {
}
cache.del(`${deviceId}_tasks_faults_operations`, err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
response.writeHead(200);
response.end();
@@ -304,10 +304,10 @@ function listener(request, response) {
const task = JSON.parse(body);
task.device = deviceId;
apiFunctions.insertTasks(task, err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
cache.del(`${deviceId}_tasks_faults_operations`, err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
if (urlParts.query.connection_request != null) {
apiFunctions.connectionRequest(deviceId, err => {
@@ -328,7 +328,7 @@ function listener(request, response) {
task._id,
DEVICE_ONLINE_THRESHOLD,
(err, status) => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
if (status === "timeout") {
response.writeHead(
@@ -343,7 +343,7 @@ function listener(request, response) {
db.tasksCollection.findOne(
{ _id: task._id },
(err, task2) => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
response.writeHead(202, "Task faulted", {
"Content-Type": "application/json"
@@ -397,7 +397,7 @@ function listener(request, response) {
{ _id: new mongodb.ObjectID(taskId) },
{ device: 1 },
(err, task) => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
if (!task) {
response.writeHead(404);
@@ -409,15 +409,15 @@ function listener(request, response) {
db.tasksCollection.remove(
{ _id: new mongodb.ObjectID(taskId) },
err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
db.faultsCollection.remove(
{ _id: `${deviceId}:task_${taskId}` },
err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
cache.del(`${deviceId}_tasks_faults_operations`, err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
response.writeHead(200);
response.end();
@@ -438,16 +438,16 @@ function listener(request, response) {
{ _id: new mongodb.ObjectID(taskId) },
{ device: 1 },
(err, task) => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
const deviceId = task.device;
db.faultsCollection.remove(
{ _id: `${deviceId}:task_${taskId}` },
err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
cache.del(`${deviceId}_tasks_faults_operations`, err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
response.writeHead(200);
response.end();
@@ -479,13 +479,13 @@ function listener(request, response) {
metadata: metadata
});
gs.open(err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
gs.write(body, err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
gs.close(err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
response.writeHead(201);
response.end();
@@ -494,7 +494,7 @@ function listener(request, response) {
});
} else if (request.method === "DELETE") {
mongodb.GridStore.unlink(db.mongoDb, filename, err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
response.writeHead(200);
response.end();
@@ -529,7 +529,7 @@ function listener(request, response) {
DELETE_DEVICE_REGEX.exec(urlParts.pathname)[1]
);
apiFunctions.deleteDevice(deviceId, err => {
if (err) return throwError(err, response);
if (err) return void throwError(err, response);
response.writeHead(200);
response.end();
@@ -617,7 +617,7 @@ function listener(request, response) {
cur.limit((limit = parseInt(urlParts.query.limit)));
cur.count(false, (err, total) => {
if (err) return throwError(err);
if (err) return void throwError(err);
response.writeHead(200, {
"Content-Type": "application/json",
@@ -646,6 +646,8 @@ function listener(request, response) {
response.end("\n]");
return false;
}
return null;
});
});
} else {