Apply consistent-return lint rule

lib/local-cache.js

@@ -70,7 +70,7 @@ function flattenObject(src, prefix = "", dst = {}) {
 
 function refresh(callback) {
   if (!nextRefresh) {
-    return setTimeout(() => {
+    return void setTimeout(() => {
       refresh(callback);
     }, 20);
   }
@@ -79,15 +79,15 @@ function refresh(callback) {
   const now = Date.now();
 
   cache.get("presets_hash", (err, dbHash) => {
-    if (err) return callback(err);
+    if (err) return void callback(err);
 
     if (hash && dbHash === hash) {
       nextRefresh = now + (REFRESH - (now % REFRESH));
-      return callback();
+      return void callback();
     }
 
     cache.lock("presets_hash_lock", 3, (err, unlockOrExtend) => {
-      if (err) return callback(err);
+      if (err) return void callback(err);
 
       let counter = 3;
 
@@ -95,13 +95,13 @@ function refresh(callback) {
       db.getPresets((err, res) => {
         if (err) {
           if (counter & 1) callback(err);
-          return (counter = 0);
+          return void (counter = 0);
         }
 
         db.getObjects((err, objects) => {
           if (err) {
             if (counter & 1) callback(err);
-            return (counter = 0);
+            return void (counter = 0);
           }
 
           objects = objects.map(obj => {
@@ -212,7 +212,7 @@ function refresh(callback) {
                 default:
                   if (counter & 1)
                     callback(new Error(`Unknown configuration type ${c.type}`));
-                  return (counter = 0);
+                  return void (counter = 0);
               }
             }
 
@@ -241,7 +241,7 @@ function refresh(callback) {
       db.getProvisions((err, res) => {
         if (err) {
           if (counter & 1) callback(err);
-          return (counter = 0);
+          return void (counter = 0);
         }
 
         provisions = {};
@@ -271,7 +271,7 @@ function refresh(callback) {
       db.getVirtualParameters((err, res) => {
         if (err) {
           if (counter & 1) callback(err);
-          return (counter = 0);
+          return void (counter = 0);
         }
 
         virtualParameters = {};
@@ -301,7 +301,7 @@ function refresh(callback) {
       db.getFiles((err, res) => {
         if (err) {
           if (counter & 1) callback(err);
-          return (counter = 0);
+          return void (counter = 0);
         }
 
         files = {};
@@ -336,7 +336,7 @@ function refresh(callback) {
 }
 
 function getPresets(callback) {
-  if (Date.now() < nextRefresh) return callback(null, hash, presets);
+  if (Date.now() < nextRefresh) return void callback(null, hash, presets);
 
   refresh(err => {
     callback(err, hash, presets);
@@ -344,7 +344,7 @@ function getPresets(callback) {
 }
 
 function getFiles(callback) {
-  if (Date.now() < nextRefresh) return callback(null, hash, files);
+  if (Date.now() < nextRefresh) return void callback(null, hash, files);
 
   refresh(err => {
     callback(err, hash, files);
@@ -353,7 +353,7 @@ function getFiles(callback) {
 
 function getProvisionsAndVirtualParameters(callback) {
   if (Date.now() < nextRefresh)
-    return callback(null, hash, provisions, virtualParameters);
+    return void callback(null, hash, provisions, virtualParameters);
 
   refresh(err => {
     callback(err, hash, provisions, virtualParameters);