Apply consistent-return lint rule

This commit is contained in:
Zaid Abdulla committed 2018-08-25 03:22:48 -07:00
1 parent d7f0b91bf0
commit d85afcd2b5
12 files changed
+264 -231

No files matched your search

+8 -8
View File
@@ -50,7 +50,7 @@ function connect(callback) {
mongodb.MongoClient.connect(
MONGODB_CONNECTION_URL,
(err, db) => {
if (err) return callback(err);
if (err) return void callback(err);
mongoDb = db;
mongoCollection = db.collection("cache");
@@ -58,7 +58,7 @@ function connect(callback) {
const now = Date.now();
mongoDb.command({ hostInfo: 1 }, (err, res) => {
if (err) return callback(err);
if (err) return void callback(err);
mongoTimeOffset = res.system.currentTime.getTime() - now;
exports.get = mongoGet;
exports.set = mongoSet;
@@ -133,7 +133,7 @@ function redisLock(lockName, ttl, callback) {
}
redisClient.set(lockName, token, "NX", "EX", ttl, (err, res) => {
if (err || res) return callback(err, unlockOrExtend);
if (err || res) return void callback(err, unlockOrExtend);
setTimeout(() => {
redisLock(lockName, ttl, callback);
@@ -145,7 +145,7 @@ function mongoGet(key, callback) {
let expire = new Date(Date.now() - mongoTimeOffset);
if (Array.isArray(key)) {
mongoCollection.find({ _id: { $in: key } }).toArray((err, res) => {
if (err) return callback(err);
if (err) return void callback(err);
let indices = {};
key.forEach((v, i) => {
@@ -160,9 +160,9 @@ function mongoGet(key, callback) {
});
} else {
mongoCollection.findOne({ _id: { $in: [key] } }, (err, res) => {
if (err || !res) return callback(err);
if (err || !res) return void callback(err);
if (res["expire"] > expire) return callback(null, res["value"]);
if (res["expire"] > expire) return void callback(null, res["value"]);
callback();
});
@@ -194,10 +194,10 @@ function mongoPop(key, callback) {
null,
{ remove: true },
(err, res) => {
if (err || !res["value"]) return callback(err);
if (err || !res["value"]) return void callback(err);
if (res["value"]["expire"] > new Date(Date.now() - mongoTimeOffset))
return callback(null, res["value"]["value"]);
return void callback(null, res["value"]["value"]);
callback();
}