From d222e488c23c717f79a3b10e905c15deccdebbb4 Mon Sep 17 00:00:00 2001 From: Zaid Abdulla Date: Mon, 11 Jun 2018 21:06:58 -0700 Subject: [PATCH] Fix taskQueue premature promise resolution --- client/task-queue.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/client/task-queue.js b/client/task-queue.js index b856a1e..e221e7e 100644 --- a/client/task-queue.js +++ b/client/task-queue.js @@ -46,7 +46,8 @@ function commit(tasks, callback) { return new Promise(resolve => { let counter = 1; - for (let [deviceId, tasks2] of Object.entries(devices)) + for (let [deviceId, tasks2] of Object.entries(devices)) { + ++counter; store .postTasks(deviceId, tasks) .then(connectionRequestStatus => { @@ -61,6 +62,7 @@ function commit(tasks, callback) { callback(deviceId, err, null, tasks2); if (--counter === 0) resolve(); }); + } if (--counter === 0) resolve(); });