From 9ba078870a14883cc269f98459b72293235dcd24 Mon Sep 17 00:00:00 2001 From: Zaid Abdulla Date: Sun, 16 Jun 2019 02:24:22 -0700 Subject: [PATCH] Fix empty preconditions not firing --- lib/local-cache.ts | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/lib/local-cache.ts b/lib/local-cache.ts index 366587c..13fbc88 100644 --- a/lib/local-cache.ts +++ b/lib/local-cache.ts @@ -158,15 +158,17 @@ async function fetchPresets(): Promise { } const events = preset["events"] || {}; - let precondition; - try { - precondition = parse(preset["precondition"]); - } catch (error) { - precondition = mongoQueryToFilter(JSON.parse(preset["precondition"])); - } + let precondition = true as Expression; + if (preset["precondition"]) { + try { + precondition = parse(preset["precondition"]); + } catch (error) { + precondition = mongoQueryToFilter(JSON.parse(preset["precondition"])); + } - // Simplify expression - precondition = expression.evaluate(precondition); + // Simplify expression + precondition = expression.evaluate(precondition); + } const _provisions = preset["provisions"] || [];