Apply prefer-const lint rule

lib/local-cache.js

@@ -35,8 +35,8 @@ let presets, provisions, virtualParameters, files;
 
 function computeHash() {
   // MD5 hash for presets, provisions, virtual parameters for detecting changes
-  let h = crypto.createHash("md5");
-  for (let p of presets) {
+  const h = crypto.createHash("md5");
+  for (const p of presets) {
     h.update(JSON.stringify(p.name));
     h.update(JSON.stringify(p.channel));
     h.update(JSON.stringify(p.schedule));
@@ -49,18 +49,18 @@ function computeHash() {
 
   keys = Object.keys(provisions).sort();
   h.update(JSON.stringify(keys));
-  for (let k of keys) h.update(provisions[k].md5);
+  for (const k of keys) h.update(provisions[k].md5);
 
   keys = Object.keys(virtualParameters).sort();
   h.update(JSON.stringify(keys));
-  for (let k of keys) h.update(virtualParameters[k].md5);
+  for (const k of keys) h.update(virtualParameters[k].md5);
 
   hash = h.digest("hex");
 }
 
 function flattenObject(src, prefix = "", dst = {}) {
-  for (let k of Object.keys(src)) {
-    let v = src[k];
+  for (const k of Object.keys(src)) {
+    const v = src[k];
     if (typeof v === "object" && !Array.isArray(v))
       flattenObject(v, `${prefix}${k}.`, dst);
     else dst[`${prefix}${k}`] = v;
@@ -122,10 +122,10 @@ function refresh(callback) {
           });
 
           presets = [];
-          for (let preset of res) {
+          for (const preset of res) {
             let schedule = null;
             if (preset.schedule) {
-              let parts = preset.schedule.trim().split(/\s+/);
+              const parts = preset.schedule.trim().split(/\s+/);
               schedule = {
                 md5: crypto
                   .createHash("md5")
@@ -146,14 +146,14 @@ function refresh(callback) {
               }
             }
 
-            let events = preset.events || {};
-            let precondition = query.convertMongoQueryToFilters(
+            const events = preset.events || {};
+            const precondition = query.convertMongoQueryToFilters(
               JSON.parse(preset.precondition)
             );
-            let _provisions = preset.provisions || [];
+            const _provisions = preset.provisions || [];
 
             // Generate provisions from the old configuration format
-            for (let c of preset.configurations) {
+            for (const c of preset.configurations) {
               switch (c.type) {
                 case "age":
                   _provisions.push(["refresh", c.name, c.age]);
@@ -176,15 +176,15 @@ function refresh(callback) {
                   break;
 
                 case "add_object":
-                  for (let obj of objects) {
+                  for (const obj of objects) {
                     if (obj["_id"] === c.object) {
-                      let alias = obj["_keys"]
+                      const alias = obj["_keys"]
                         .map(k => `${k}:${JSON.stringify(obj[k])}`)
                         .join(",");
-                      let p = `${c.name}.[${alias}]`;
+                      const p = `${c.name}.[${alias}]`;
                       _provisions.push(["instances", p, 1]);
 
-                      for (let k in obj) {
+                      for (const k in obj) {
                         if (
                           !k.startsWith("_") &&
                           !(obj["_keys"].indexOf(k) !== -1)
@@ -197,12 +197,12 @@ function refresh(callback) {
                   break;
 
                 case "delete_object":
-                  for (let obj of objects) {
+                  for (const obj of objects) {
                     if (obj["_id"] === c.object) {
-                      let alias = obj["_keys"]
+                      const alias = obj["_keys"]
                         .map(k => `${k}:${JSON.stringify(obj[k])}`)
                         .join(",");
-                      let p = `${c.name}.[${alias}]`;
+                      const p = `${c.name}.[${alias}]`;
                       _provisions.push(["instances", p, 0]);
                     }
                   }
@@ -245,7 +245,7 @@ function refresh(callback) {
         }
 
         provisions = {};
-        for (let r of res) {
+        for (const r of res) {
           provisions[r._id] = {};
           provisions[r._id].md5 = crypto
             .createHash("md5")
@@ -275,7 +275,7 @@ function refresh(callback) {
         }
 
         virtualParameters = {};
-        for (let r of res) {
+        for (const r of res) {
           virtualParameters[r._id] = {};
           virtualParameters[r._id].md5 = crypto
             .createHash("md5")
@@ -305,7 +305,7 @@ function refresh(callback) {
         }
 
         files = {};
-        for (let r of res) {
+        for (const r of res) {
           const id = r.filename || r._id.toString();
           files[id] = {};
           files[id].length = r.length;