Apply prefer-const lint rule

lib/cwmp.js

@@ -288,7 +288,7 @@ function applyPresets(sessionContext) {
     const RETRY_DELAY = config.get("RETRY_DELAY", sessionContext.deviceId);
 
     if (sessionContext.faults) {
-      for (let [channel, fault] of Object.entries(sessionContext.faults)) {
+      for (const [channel, fault] of Object.entries(sessionContext.faults)) {
         let retryTimestamp = 0;
         if (!fault.retryNow) {
           retryTimestamp =
@@ -327,7 +327,7 @@ function applyPresets(sessionContext) {
       }
 
       let eventsMatch = true;
-      for (let [k, v] of Object.entries(preset.events)) {
+      for (const [k, v] of Object.entries(preset.events)) {
         if (!v !== !deviceEvents[k.replace(/\s+/g, "_")]) {
           eventsMatch = false;
           break;
@@ -346,7 +346,7 @@ function applyPresets(sessionContext) {
       }
 
       filteredPresets.push(preset);
-      for (let k of Object.keys(preset.precondition)) {
+      for (const k of Object.keys(preset.precondition)) {
         sessionContext.channels[preset.channel] = 0;
         const p = k.split(/([^a-zA-Z0-9\-_.].*)/, 1)[0];
         parameters[p] = common.parsePath(p);
@@ -354,7 +354,7 @@ function applyPresets(sessionContext) {
     }
 
     const declarations = [];
-    for (let v of Object.values(parameters))
+    for (const v of Object.values(parameters))
       declarations.push([v, 1, { value: 1 }]);
 
     session.rpcRequest(
@@ -374,7 +374,7 @@ function applyPresets(sessionContext) {
         session.clearProvisions(sessionContext);
 
         const parameterValues = {};
-        for (let [k, v] of Object.entries(parameters)) {
+        for (const [k, v] of Object.entries(parameters)) {
           const unpacked = device.unpack(deviceData, v);
           if (!unpacked[0]) continue;
           const attrs = deviceData.attributes.get(unpacked[0]);
@@ -398,7 +398,7 @@ function applyPresets(sessionContext) {
           }
         }
 
-        for (let [channel, provisions] of Object.entries(
+        for (const [channel, provisions] of Object.entries(
           appendProvisionsToFaults
         )) {
           if (
@@ -484,7 +484,7 @@ function nextRpc(sessionContext) {
 
     if (acsRequest) return void sendAcsRequest(sessionContext, id, acsRequest);
 
-    for (let [channel, flags] of Object.entries(sessionContext.channels)) {
+    for (const [channel, flags] of Object.entries(sessionContext.channels)) {
       if (flags && sessionContext.faults[channel]) {
         delete sessionContext.faults[channel];
         if (!sessionContext.faultsTouched) sessionContext.faultsTouched = {};
@@ -980,8 +980,8 @@ function processRequest(sessionContext, rpc) {
     session.timeoutOperations(sessionContext, (err, faults, operations) => {
       if (err) return void throwError(err, sessionContext.httpResponse);
 
-      for (let i of faults) {
-        for (let [k, v] of Object.entries(operations[i].retries))
+      for (const i of faults) {
+        for (const [k, v] of Object.entries(operations[i].retries))
           sessionContext.retries[k] = v;
 
         recordFault(
@@ -1118,7 +1118,7 @@ function listener(httpRequest, httpResponse) {
         return;
       }
 
-      let parseWarnings = [];
+      const parseWarnings = [];
       let rpc;
       try {
         rpc = soap.request(
@@ -1198,7 +1198,7 @@ function listener(httpRequest, httpResponse) {
               _sessionContext.cacheUntil = cacheUntil;
               _sessionContext.faults = faults;
               _sessionContext.retries = {};
-              for (let [k, v] of Object.entries(_sessionContext.faults)) {
+              for (const [k, v] of Object.entries(_sessionContext.faults)) {
                 if (v.expiry >= _sessionContext.timestamp) {
                   // Delete expired faults
                   delete _sessionContext.faults[k];