Only send UDP con req if STUNEnable is true
Because even when STUN is not enabled, the param UDPConnectionRequestAddress will still hold IP of the listening interface which we can't reach.
This commit is contained in:
1 parent
0e0380917f
commit
081201cd2f
1 file changed
+7
-1
@@ -50,6 +50,7 @@ export async function connectionRequest(
|
|||||||
|
|
||||||
let connectionRequestUrl,
|
let connectionRequestUrl,
|
||||||
udpConnectionRequestAddress,
|
udpConnectionRequestAddress,
|
||||||
|
stunEnable,
|
||||||
connReqJabberId,
|
connReqJabberId,
|
||||||
username,
|
username,
|
||||||
password;
|
password;
|
||||||
@@ -63,6 +64,9 @@ export async function connectionRequest(
|
|||||||
"InternetGatewayDevice.ManagementServer.UDPConnectionRequestAddress"
|
"InternetGatewayDevice.ManagementServer.UDPConnectionRequestAddress"
|
||||||
] || {}
|
] || {}
|
||||||
).value || [""])[0];
|
).value || [""])[0];
|
||||||
|
stunEnable = ((
|
||||||
|
device["InternetGatewayDevice.ManagementServer.STUNEnable"] || {}
|
||||||
|
).value || [""])[0];
|
||||||
connReqJabberId = ((
|
connReqJabberId = ((
|
||||||
device["InternetGatewayDevice.ManagementServer.ConnReqJabberID"] || {}
|
device["InternetGatewayDevice.ManagementServer.ConnReqJabberID"] || {}
|
||||||
).value || [""])[0];
|
).value || [""])[0];
|
||||||
@@ -83,6 +87,8 @@ export async function connectionRequest(
|
|||||||
udpConnectionRequestAddress = ((
|
udpConnectionRequestAddress = ((
|
||||||
device["Device.ManagementServer.UDPConnectionRequestAddress"] || {}
|
device["Device.ManagementServer.UDPConnectionRequestAddress"] || {}
|
||||||
).value || [""])[0];
|
).value || [""])[0];
|
||||||
|
stunEnable = ((device["Device.ManagementServer.STUNEnable"] || {})
|
||||||
|
.value || [""])[0];
|
||||||
connReqJabberId = ((device["Device.ManagementServer.ConnReqJabberID"] || {})
|
connReqJabberId = ((device["Device.ManagementServer.ConnReqJabberID"] || {})
|
||||||
.value || [""])[0];
|
.value || [""])[0];
|
||||||
username = ((
|
username = ((
|
||||||
@@ -159,7 +165,7 @@ export async function connectionRequest(
|
|||||||
const debug = !!getConfig(snapshot, "cwmp.debug", {}, now, evalCallback);
|
const debug = !!getConfig(snapshot, "cwmp.debug", {}, now, evalCallback);
|
||||||
|
|
||||||
let udpProm;
|
let udpProm;
|
||||||
if (udpConnectionRequestAddress) {
|
if (udpConnectionRequestAddress && +stunEnable) {
|
||||||
udpProm = udpConnectionRequest(
|
udpProm = udpConnectionRequest(
|
||||||
udpConnectionRequestAddress,
|
udpConnectionRequestAddress,
|
||||||
authExp,
|
authExp,
|
||||||
|
|||||||
Reference in new issue
Block a user